[Forwardport] Fix sitemap grid render incorrect base urls for multiple stores#18228
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Oct 3, 2018
nntoan:2.3-develop-PR-port-18000
Merged
[Forwardport] Fix sitemap grid render incorrect base urls for multiple stores#18228magento-engcom-team merged 1 commit intomagento:2.3-developfrom nntoan:2.3-develop-PR-port-18000
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
nntoan:2.3-develop-PR-port-18000
Conversation
Contributor
|
Hi @nntoan. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sidolov
approved these changes
Sep 25, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 3, 2018
…s for multiple stores #18228
Contributor
|
Hi @nntoan. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#18000
Description
In
Magento/Sitemap/Block/Adminhtml/Grid/Renderer/Link.php, we've created new instance for\Magento\Sitemap\Model\Sitemap. That lead to$sitemap->getStoreId()isNULLall the time, thesitemap.xmlgenerated still using correct store id because of we load$sitemapinstance from the collection which retrieve data directly from the database.So to fix this issue, we should set the store id for the current sitemap object based on store id retrieved from the current row.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist